(wrong branch - feta) #5901

Jon-edge · 2026-01-15T23:32:56Z

PR opened on wrong branch

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

Yes
No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

Tested on iOS device
Tested on Android device
Tested on small-screen device (iPod Touch)
Tested on large-screen device (tablet)

Note

Fix iOS in‑app reviews (18+)

Pin react-native-store-review to a GitHub fork and apply a patch: add DEFINES_MODULE/SWIFT_VERSION in podspec and switch to framework header import (RNStoreReview-Swift.h) for iOS build compatibility
Update Podfile.lock and yarn.lock to the patched module
Call requestReview() in HomeScene to surface the in‑app review prompt
Add CHANGELOG entry: fixed: In-app review for iOS 18+
Minor: ScanModal uses SceneHeaderUi4, improves camera permission handling and typing, and adjusts header spacing

^{Written by Cursor Bugbot for commit 7a4ce5b. This will update automatically on new commits. Configure here.}

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1212758184297415

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c4ee59259c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-01-15T23:35:10Z

patches/react-native-store-review+0.4.3.patch

+import Foundation
+import StoreKit


Import UIKit so UIApplication is in scope

The new Swift helper uses UIApplication/UIWindowScene in requestReview, but StoreReview.swift only imports Foundation and StoreKit here. Swift doesn’t re-export UIKit from StoreKit, so this will fail to compile with “Cannot find 'UIApplication' in scope” when the patch is applied. Add import UIKit to ensure the symbols are available.

Useful? React with 👍 / 👎.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

cursor · 2026-01-16T21:47:39Z

src/components/modals/ScanModal.tsx

+  const reduxCameraPermission = useSelector(state => state.permissions.camera)
+  const [cameraPermission, setCameraPermission] = React.useState(
+    reduxCameraPermission
+  )


Local permission state doesn't sync with Redux updates

Medium Severity

The cameraPermission local state is initialized from reduxCameraPermission but never syncs with Redux updates after mount. When a user grants camera permission via OS Settings and returns to the app, PermissionsManager updates Redux, but the local cameraPermission state remains stale. This leaves users stuck on the permission-denied view even after granting permission, requiring them to close and reopen the modal.

Additional Locations (1)

src/components/modals/ScanModal.tsx#L90-L101

I agree that this is the wrong solution. We don't want to track state locally in the component - that's the job of the permission subsystem. The problem is that the permission subsystem is modifying things and then forgetting to update redux.

Over in the permissions manager, we should do this:

/** * Checks permission and attempts to request permissions (only if checked * permission was 'denied') */ export const checkAndRequestPermission = (permission: Permission): ThunkAction<Promise<PermissionStatus>> => async dispatch => { const status: PermissionStatus = await check(permissionNames[permission]) if (status !== 'denied') return status const newStatus = await request(permissionNames[permission]) if (newStatus !== status) { dispatch({ type: 'PERMISSIONS/UPDATE', data: { [permission]: newStatus } }) } return newStatus }

And then here is just becomes:

- checkAndRequestPermission('camera') + dispatch(checkAndRequestPermission('camera'))

And presto! The permissions manager is updating redux so this scene works correctly.

Package is not being maintained as of 2023. A forked branch and PR addresses iOS 18+ support: oblador/react-native-store-review@575f492 - The dependency now points to the above fork/SHA - Patched to add the missing Swifth module configuration to the podspec, and to import using angle brackets in the swift code.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

cursor · 2026-01-16T22:26:02Z

src/components/scenes/HomeScene.tsx

 import FastImage from 'react-native-fast-image'
 import Animated from 'react-native-reanimated'
 import { useSafeAreaFrame } from 'react-native-safe-area-context'
+import { requestReview } from 'react-native-store-review/src'


Wrong import bypasses review logic, breaks Android

High Severity

The requestReview function is imported directly from react-native-store-review/src instead of using the existing wrapper in src/actions/RequestReviewActions.tsx. The native module only works on iOS, leaving Android users without in-app review functionality. Additionally, this bypasses the app's sophisticated review trigger system that tracks user actions, respects cooldown periods, and provides Android fallback handling with a modal dialog.

Additional Locations (1)

src/components/scenes/HomeScene.tsx#L150-L151

Yes, what Cursor said. Is this a debugging commit for QA? In that case, just be sure to drop it before merge.

This PR is for the wrong branch - this is the feta test build to allow QA to test easily.

swansontec · 2026-01-16T22:27:12Z

src/components/modals/ScanModal.tsx

-    checkAndRequestPermission('camera').catch(err => {
-      showError(err)
-    })
+    checkAndRequestPermission('camera').catch(showError)


So we can't just do .catch(showError), because then ScanModal.ts won't appear in the stack trace. We have to do .catch((error: unknown) => showError(error)), even though that's way more annoying.

swansontec · 2026-01-16T22:27:36Z

src/components/modals/ScanModal.tsx

-          .catch(error => {
-            showDevError(error)
-          })
+          .catch(showDevError)


swansontec · 2026-01-16T22:27:42Z

src/components/modals/ScanModal.tsx

-    ).catch(err => {
-      showError(err)
-    })
+    ).catch(showError)


swansontec · 2026-01-16T22:28:33Z

src/components/modals/ScanModal.tsx

+  const handleClose = (): void => {
    triggerHaptic('impactLight')
-    // @ts-expect-error
+    // @ts-expect-error - AirshipBridge expects string | undefined but resolve() with no args is valid


In that case, would bridge.resolve(undefined) allow us to get rid of the // @ts-expect-error altogether?

swansontec · 2026-01-16T22:29:06Z

src/components/modals/ScanModal.tsx

    (peepholeSpaceLayout.height - holeSize) / 2

-  const renderModalContent = () => {
+  const renderModalContent = (): React.JSX.Element | null => {


React.ReactElement is the preferred return type.

swansontec · 2026-01-16T22:40:40Z

src/components/modals/ScanModal.tsx

+  const reduxCameraPermission = useSelector(state => state.permissions.camera)
+  const [cameraPermission, setCameraPermission] = React.useState(
+    reduxCameraPermission
+  )


I agree that this is the wrong solution. We don't want to track state locally in the component - that's the job of the permission subsystem. The problem is that the permission subsystem is modifying things and then forgetting to update redux.

Over in the permissions manager, we should do this:

/** * Checks permission and attempts to request permissions (only if checked * permission was 'denied') */ export const checkAndRequestPermission = (permission: Permission): ThunkAction<Promise<PermissionStatus>> => async dispatch => { const status: PermissionStatus = await check(permissionNames[permission]) if (status !== 'denied') return status const newStatus = await request(permissionNames[permission]) if (newStatus !== status) { dispatch({ type: 'PERMISSIONS/UPDATE', data: { [permission]: newStatus } }) } return newStatus }

And then here is just becomes:

- checkAndRequestPermission('camera') + dispatch(checkAndRequestPermission('camera'))

And presto! The permissions manager is updating redux so this scene works correctly.

swansontec · 2026-01-16T22:51:52Z

src/components/scenes/HomeScene.tsx

 import FastImage from 'react-native-fast-image'
 import Animated from 'react-native-reanimated'
 import { useSafeAreaFrame } from 'react-native-safe-area-context'
+import { requestReview } from 'react-native-store-review/src'


Yes, what Cursor said. Is this a debugging commit for QA? In that case, just be sure to drop it before merge.

Jon-edge · 2026-01-16T23:07:56Z

Closing this since it was opened on a test build and referencing in relevant PR: #5906

Jon-edge force-pushed the test-feta branch from c4ee592 to cbeefaf Compare January 15, 2026 23:34

chatgpt-codex-connector bot reviewed Jan 15, 2026

View reviewed changes

Jon-edge added 2 commits January 16, 2026 13:39

Address warnings in ScanModal

f7e37b6

Fix camera permissions race condition

d44e0a2

Jon-edge force-pushed the test-feta branch from cbeefaf to d44e0a2 Compare January 16, 2026 21:41

cursor bot reviewed Jan 16, 2026

View reviewed changes

Jon-edge added 2 commits January 16, 2026 14:12

Force in-app review

7a4ce5b

cursor bot reviewed Jan 16, 2026

View reviewed changes

swansontec requested changes Jan 16, 2026

View reviewed changes

Jon-edge changed the title ~~Patch react-native-store-review~~ (wrong branch - feta) Jan 16, 2026

Jon-edge closed this Jan 16, 2026

Jon-edge mentioned this pull request Jan 16, 2026

iOS Camera Permission #5906

Merged

6 tasks

(wrong branch - feta) #5901

(wrong branch - feta) #5901

Conversation

Jon-edge commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CHANGELOG

Dependencies

Requirements

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Jan 16, 2026

Choose a reason for hiding this comment

Local permission state doesn't sync with Redux updates

Uh oh!

swansontec Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Jan 16, 2026

Choose a reason for hiding this comment

Wrong import bypasses review logic, breaks Android

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

swansontec Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jon-edge commented Jan 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Jon-edge commented Jan 15, 2026 •

edited

Loading

swansontec Jan 16, 2026 •

edited

Loading

swansontec Jan 16, 2026 •

edited

Loading